ref: Remove deprecated app start option #6460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6460 +/- ##
=============================================
- Coverage 87.023% 87.022% -0.002%
=============================================
Files 450 451 +1
Lines 37806 37741 -65
Branches 17494 17471 -23
=============================================
- Hits 32900 32843 -57
+ Misses 4863 4855 -8
Partials 43 43
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7123d8e | 1222.27 ms | 1262.02 ms | 39.76 ms |
| 5258fb8 | 1207.92 ms | 1234.51 ms | 26.59 ms |
| 07d7e83 | 1211.71 ms | 1240.08 ms | 28.37 ms |
| be882e4 | 1199.35 ms | 1231.20 ms | 31.86 ms |
| 4e3915a | 1230.02 ms | 1258.90 ms | 28.88 ms |
| 7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
| 7bd90de | 1233.48 ms | 1249.47 ms | 15.99 ms |
| f4f94f5 | 1216.24 ms | 1247.94 ms | 31.70 ms |
| 7416ffc | 1225.55 ms | 1241.80 ms | 16.25 ms |
| d7461dc | 1233.69 ms | 1255.29 ms | 21.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7123d8e | 23.75 KiB | 986.80 KiB | 963.05 KiB |
| 5258fb8 | 23.75 KiB | 874.45 KiB | 850.70 KiB |
| 07d7e83 | 23.75 KiB | 913.27 KiB | 889.52 KiB |
| be882e4 | 23.75 KiB | 946.69 KiB | 922.94 KiB |
| 4e3915a | 23.75 KiB | 858.69 KiB | 834.94 KiB |
| 7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
| 7bd90de | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| f4f94f5 | 23.75 KiB | 988.02 KiB | 964.27 KiB |
| 7416ffc | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| d7461dc | 23.75 KiB | 874.45 KiB | 850.70 KiB |
philprime
approved these changes
Oct 20, 2025
|
@philprime I was surprised as well, it seems like it was only retained to keep the public API from breaking |
noahsmartin
force-pushed
the
removeDeprecatedAppStart
branch
3 times, most recently
from
d435a30 to
c27f7dd
Compare
noahsmartin
force-pushed
the
removeDeprecatedAppStart
branch
from
c27f7dd to
3a02f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully removes "enableAppLaunchProfiling" which is removed in V9
#skip-changelog
Closes #6461